Jens-G commented on code in PR #3475:
URL: https://github.com/apache/thrift/pull/3475#discussion_r3243849803
##########
compiler/cpp/src/thrift/generate/t_js_generator.cc:
##########
@@ -2397,6 +2400,7 @@ void t_js_generator::generate_deserialize_struct(ostream&
out, t_struct* tstruct
void t_js_generator::generate_deserialize_container(ostream& out, t_type*
ttype, string prefix) {
string size = tmp("_size");
string rtmp3 = tmp("_rtmp3");
+ string seen; // populated only for sets, used for O(n) duplicate detection
on read
Review Comment:
The comment seems off: O(n) or O(1) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
