ctubbsii commented on code in PR #3491:
URL: https://github.com/apache/thrift/pull/3491#discussion_r3251557346


##########
.asf.yaml:
##########
@@ -1,8 +1,21 @@
 notifications:
-    commits:      [email protected]
-    issues:       [email protected]
-    pullrequests_status: [email protected]
-    pullrequests_comment: [email protected]
-    jira_options: link label worklog
-    
-    
\ No newline at end of file
+  commits: [email protected]
+  issues: [email protected]
+  pullrequests_status: [email protected]
+  pullrequests_comment: [email protected]
+  jira_options: link label worklog
+
+github:
+  rulesets:
+    - name: "Default Branch Protection"
+      type: branch
+      branches:
+        includes:
+          - "~DEFAULT_BRANCH"
+          - "release/*"
+          - "rel/*"

Review Comment:
   Because some projects have subprojects (multiple releases, with different 
names), I think it's a good opportunity to start using better tag names instead 
of just the raw version numbers, as in `rel/thrift-0.24.0`. If there's any 
sub-projects, like "thrift-examples", then it could be 
`rel/thrift-examples-1.0.0`, for example.
   
   Having all the releases under one tag namespace allows other kinds of tags 
to be used for other purposes in their own namespace that don't look like 
`rel/` (e.g. release candidates, tests, abandoned branches, etc.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to