murfffi commented on code in PR #3488:
URL: https://github.com/apache/thrift/pull/3488#discussion_r3252234326
##########
lib/go/thrift/socket_unix_conn.go:
##########
@@ -38,7 +39,14 @@ func (sc *socketConn) read0() error {
}
func (sc *socketConn) checkConn() error {
- syscallConn, ok := sc.Conn.(syscall.Conn)
+ rawConn := sc.Conn
+ syscallConn, ok := rawConn.(syscall.Conn)
+ if !ok {
+ if connTLS, isTLS := rawConn.(*tls.Conn); isTLS {
+ rawConn = connTLS.NetConn()
Review Comment:
I reviewed https://github.com/golang/go/issues/44506 - the issue tracking
kernel TLS support in Go . It is in state Proposal-Accepted but not
implemented. A couple of people implemented crypto/tls forks as PoC. I think
the point still stands - there is no value to check if tls.Conn implements
syscall.Conn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
