Jens-G commented on code in PR #3503: URL: https://github.com/apache/thrift/pull/3503#discussion_r3277714597
########## doc/specs/thrift-compact-protocol.md: ########## @@ -159,17 +170,16 @@ field-header ::= field-type field-id ``` Because each field header contains the field-id (as defined by the Thrift IDL file), the fields can be encoded in any -order. Thrift's type system is not extensible; you can only encode the primitive types and structs. Therefore is also -possible to handle unknown fields while decoding; these are simply ignored. While decoding the field type can be used to -determine how to decode the field value. +order. Thrift's type system is not extensible; you can only encode the primitive types and structs. Therefore it is also +possible to handle unknown fields while decoding by ignoring them. The field type is used to determine how to decode field values. -Note that the field name is not encoded so field renames in the IDL do not affect forward and backward compatibility. +Note that the fields are identified by their integer value and not thier name. Review Comment: not "their name"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
