Jens-G commented on PR #3525: URL: https://github.com/apache/thrift/pull/3525#issuecomment-4529873812
### Code review Found 2 issues: 1. `test_inline_at_sign_not_treated_as_tag` asserts that `"@param"` appears in the `plain` function's documentation section, but `DocTest.thrift` gives `plain` only the docstring `"Plain prose doc, no @param or @return tags."` — the generated Markdown will never contain `"@param"` there, so the `assertIn` will always fail. https://github.com/apache/thrift/blob/871ad14aa9d0bdd290af0f06a249650a8b241c19/compiler/cpp/test/compiler/markdown_doc_test.py#L99-L103 2. The PR test plan leaves the `make style` checkbox unchecked, acknowledging `clang-format` was not run. [AGENTS.md](https://github.com/apache/thrift/blob/871ad14aa9d0bdd290af0f06a249650a8b241c19/AGENTS.md) requires "Verify coding standards: `make style`" (Section 3) and lists it as a mandatory pre-PR checklist item (Section 6). https://github.com/apache/thrift/blob/871ad14aa9d0bdd290af0f06a249650a8b241c19/AGENTS.md#L51-L51 🤖 Generated with [Claude Code](https://claude.ai/code) <sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
