jimexist opened a new pull request, #3526: URL: https://github.com/apache/thrift/pull/3526
## Summary Upgrades the `ws` WebSocket library from `^5.2.3` (resolved 5.2.4) to `^8.21.0`. ws 5.x has been EOL for years and is several major versions behind the current release. `ws` is consumed indirectly through `isomorphic-ws` in [lib/nodejs/lib/thrift/ws_connection.js](https://github.com/apache/thrift/blob/master/lib/nodejs/lib/thrift/ws_connection.js); only the client-side `new WebSocket(uri, "", wsOptions)` constructor is used, which is unchanged across v5 → v8. No server-side `ws.Server` API is used in the codebase, so the breaking changes between v5 and v8 (most of which affect the server API) do not apply. ## Compatibility - **Node engine**: ws v8 requires Node.js ≥ 10.0.0; `package.json`'s `engines.node` is already `>= 10.18.0`, so the constraint is satisfied. - **Lock file**: the transitive `async-limiter` dependency (only needed by ws 5.x) is removed. - **License**: `ws` is BSD-2-Clause (ASF Category A), so no `LICENSE` / `NOTICE` updates are required. ## Notes for reviewers - No JIRA ticket was filed; this is a dependency bump that does not touch product code. Happy to open one if maintainers prefer. - The change is AI-assisted; commit and PR are labelled per `AGENTS.md` / `CONTRIBUTING.md` (`Co-Authored-By` / `Generated-by`). ## Test plan - [ ] `npm install` resolves cleanly - [ ] `lib/nodejs/test/testAll.sh` passes - [ ] WebSocket transport sanity check (e.g. `lib/nodejs/test/server.js` + WS client) succeeds 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
