sveneld opened a new pull request, #3531: URL: https://github.com/apache/thrift/pull/3531
<!-- Explain the changes in the pull request below: --> Resolves [THRIFT-4171](https://issues.apache.org/jira/browse/THRIFT-4171). `TSocket::setSendTimeout()` was the only way to set the timeout passed to `fsockopen()`/`pfsockopen()`, so callers had to choose between a short connect timeout (good) and a short write timeout (often unwanted). Adds a separate `setConnectTimeout(int $timeout)` method; if it is not called, `open()` falls back to the send timeout, preserving today's behaviour. Two unit tests cover both paths: the BC fallback and the override. This addresses the same problem as the original PR #744, restructured around the typed properties introduced in recent PHP-library refactors. - [x] [Apache JIRA](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket: THRIFT-4171 - [x] Title follows `THRIFT-NNNN: …` - [x] Squashed to a single commit - [x] No breaking change — additive method; existing callers keep current behaviour - [ ] `[skip ci]` (n/a — code change) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
