sveneld commented on PR #3532:
URL: https://github.com/apache/thrift/pull/3532#issuecomment-4548337635
Closing — the test was misaimed. THRIFT-1209 was about the legacy
non-namespaced PHP generator output (`final class metastore_HiveObjectType {
const GLOBAL = 1; ... }`) failing on older PHP. That was resolved by two
independent refactors: (1) the PHP minimum bump to 8.1 (THRIFT-5956 / PHP 7.1+
allows reserved words as class constants), and (2) the namespaced PHP generator
output. Adding a regression test today tests the current behaviour rather than
the original bug. Will note that on the JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
