Jens-G opened a new pull request, #3562:
URL: https://github.com/apache/thrift/pull/3562

   ## Summary
   
   Wires `IncrementRecursionDepth` / `DecrementRecursionDepth` into 
`ReadStructBegin` / `ReadStructEnd` / `WriteStructBegin` / `WriteStructEnd` for 
all three Delphi protocol implementations (Binary, Compact, JSON).
   
   The infrastructure (`TProtocolRecursionTrackerImpl`, 
`IncrementRecursionDepth`, `DecrementRecursionDepth`, 
`TProtocolExceptionDepthLimit`) has existed in the Delphi library for some time 
but was never connected to the struct read/write entry points.
   
   Default limit: 64 levels (from 
`TThriftConfigurationImpl.DEFAULT_RECURSION_LIMIT`).
   
   No codegen changes needed — the generated `Read`/`Write` methods already 
call `ReadStructBegin`/`WriteStructBegin` on the protocol.
   
   ## Test plan
   
   - Added `RecursionDepthTest` to 
`lib/delphi/test/testsuite/client/UnitTests.pas`
   - Tests write path for Binary, Compact, and JSON protocols
   - Tests read path for Binary and Compact protocols
   - Each test confirms `TProtocolExceptionDepthLimit` is raised on the 
(limit+1)-th nested `ReadStructBegin` / `WriteStructBegin` call
   
   🤖 Generated with [Claude Code](https://claude.ai/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to