sveneld commented on code in PR #3552:
URL: https://github.com/apache/thrift/pull/3552#discussion_r3330014935


##########
lib/php/lib/Base/TBase.php:
##########
@@ -380,36 +385,41 @@ private function writeList(array $var, array $spec, 
TProtocol $output, bool $set
     protected function writeStruct(string $class, array $spec, TProtocol 
$output): int

Review Comment:
   Same logic is in 
https://github.com/apache/thrift/blob/master/lib/php/lib/Exception/TException.php
 it should be also updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to