Jens-G opened a new pull request, #3580: URL: https://github.com/apache/thrift/pull/3580
## THRIFT-6065: Use TMemoryStream in the Haxe recursion-depth test Follow-up to #3579. Now that `TMemoryStream` grows on write, the recursion-depth round-trip test no longer needs a temporary file: a single in-memory stream is written, rewound (`Position = 0`) and read back. Removes from `RecursionLimitTest`: - the `TFileStream` usage and the `recursion.tmp` temp file; - `closeQuietly()` (added so a read/write that threw `DEPTH_LIMIT` didn't leave a file handle open and break the next case on **Windows**); - the surrounding `try/finally` file cleanup. The nine checks (struct/union/exception × round-trip / over-write / over-read) are unchanged in intent and were re-verified. > **Depends on #3579** (the `TMemoryStream` fix). This branch is stacked on it, so until #3579 merges the diff/commits here include that fix as well; once #3579 lands this narrows to just the test change. The test would fail against current `master` (where `TMemoryStream` can't be written), which is exactly the bug #3579 fixes. Validated locally on neko (Haxe lib unit tests have no CI job): the full Normal-mode suite passes — `StreamTest` (incl. the new in-memory cases) and all nine `RecursionLimitTest` checks — with no temp file created. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
