Jens-G commented on PR #3588: URL: https://github.com/apache/thrift/pull/3588#issuecomment-4653604428
Thanks for the review @santiagomed! Addressed all three points in the latest commit: - **Suggestion**: Split into two jobs — `dry-run` (runs on all triggers, no `environment` / no `id-token: write`) and `publish` (job-level `if: release && !prerelease`, keeps `environment: release` and OIDC) - **Nit 1**: Pinned `RUSTUP_TOOLCHAIN` to `"1.85"` (the minimum verified to work with `getrandom >= 0.4`) with an explicit `rustup toolchain install` step; added a comment explaining why - **Nit 2**: Added a version-consistency check step in the `publish` job that extracts the version from `lib/rs/Cargo.toml` and compares it against the release tag (stripping a leading `v`), failing early before auth if they differ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
