santiagomed commented on PR #3546: URL: https://github.com/apache/thrift/pull/3546#issuecomment-4665954289
> ### Code review > Found 1 issue: > > 1. The new option-parsing loop throws `"unknown option: " + iter->first`, but every other generator in the codebase uses a language-prefixed form (e.g., `"unknown option py:"`, `"unknown option cpp:"`). The RS generator should throw `"unknown option rs:" + iter->first` to follow the established convention and help users identify which generator rejected their flag. > > https://github.com/apache/thrift/blob/4ce48981d839389c4a4a184d98869381f647a2fb/compiler/cpp/src/thrift/generate/t_rs_generator.cc#L61-L67 > > 🤖 Generated with [Claude Code](https://claude.ai/code) > > - If this code review was useful, please react with 👍. Otherwise, react with 👎. Thanks for the review @Jens-G. Addressed this + added some additional fixes specified in the summary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
