HTHou commented on PR #3600: URL: https://github.com/apache/thrift/pull/3600#issuecomment-4731877125
Thanks @Jens-G, addressed both in the latest push. - Moved `ctx_.reset()` back under `TSSLSocketFactory::mutex_` via `cleanupOpenSSLState()`, preserving the THRIFT-2225 locking/order. - Made the `SSL_OP_NO_*` option assertions conditional at runtime when each option bit is observable, including the custom-context checks. Validation run locally: - `git diff --check` - object compile of `TSSLSocket.cpp` and `SecurityTest.cpp` with OpenSSL 3 / Homebrew Boost -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
