Jens-G commented on PR #3604:
URL: https://github.com/apache/thrift/pull/3604#issuecomment-4746538888

   ### Code review
   
   Reviewed and applied as a maintainer edit. The binary and compact prechecks 
are widened correctly. On the JSON path the element count is a wire-supplied 
`int64`, so I added a range check on the count before the 64-bit multiply in 
`checkContainerSizeForProtocol`, with regression tests (a helper unit case and 
a `TJSONProtocol` map case). Also tidied the wording in the description and a 
test comment to keep it functional.
   
   Thanks @dxbjavid — kept you as the author of the original commit.
   
   🤖 Generated with [Claude Code](https://claude.ai/code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to