Copilot commented on code in PR #3608:
URL: https://github.com/apache/thrift/pull/3608#discussion_r3483791499
##########
lib/js/package.json:
##########
@@ -21,10 +21,13 @@
"grunt-contrib-uglify": "~4.0",
"grunt-jsdoc": "~2.4",
"grunt-shell-spawn": "~0.4",
- "jsdoc": "^3.6.7",
+ "jsdoc": "^4.0.0",
"jslint": "~0.12.1",
"json-int64": "~1.0.2",
"node-int64": "~0.4.0",
"nopt": "~4.0"
+ },
+ "overrides": {
+ "jsdoc": "^4.0.0"
}
Review Comment:
The override is currently global ("overrides": { "jsdoc": ... }), which will
force *any* future dependency on `jsdoc` to 4.x. Since the intent described in
the PR is specifically to make `grunt-jsdoc` use JSDoc 4, scoping the override
to `grunt-jsdoc` reduces the chance of unintentionally affecting unrelated
packages while achieving the same result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
