Jens-G commented on PR #3607: URL: https://github.com/apache/thrift/pull/3607#issuecomment-4813638004
### Code review Found 2 issues: 1. `testframedtransport_LDADD` in `Makefile.am` does not include `thrift_memory_buffer.o`, but the new `test_read_across_frames` uses `THRIFT_TYPE_MEMORY_BUFFER`. `CMakeLists.txt` masks this by linking the full `thrift_c_glib` library, but autotools builds will fail at link time with undefined references. Other tests in this directory that use `ThriftMemoryBuffer` include the `.c` file directly (e.g. `#include "../src/thrift/c_glib/transport/thrift_memory_buffer.c"`). https://github.com/apache/thrift/blob/f20a320c2c6ba061e918751210267b7318635ff1/lib/c_glib/test/Makefile.am#L156-L163 2. The fix in `thrift_buffered_transport_read_slow` has no regression test. The equivalent fix in `thrift_framed_transport_read_slow` gets `test_read_across_frames`, but `testbufferedtransport.c` has nothing that exercises the `have > 0` branch. Per CONTRIBUTING.md, tests are required for every submitted change. https://github.com/apache/thrift/blob/f20a320c2c6ba061e918751210267b7318635ff1/lib/c_glib/src/thrift/c_glib/transport/thrift_buffered_transport.c#L93-L100 🤖 Generated with [Claude Code](https://claude.ai/code) <sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
