Jens-G commented on PR #3594: URL: https://github.com/apache/thrift/pull/3594#issuecomment-4947855534
### Code review Found 1 issue: 1. `decode_binary_from_bytes` doesn't accept or propagate `string_length_limit`/`container_length_limit`, unlike `decode_binary`/ `decode_compact`, which read both off the caller's protocol object and apply them before decoding. https://github.com/apache/thrift/blob/2ea47349186d08a60a51e477f85d811a43940a8f/lib/py/src/ext/module.cpp#L142-L163 For comparison, `decode_impl` wires the limits through from `oprot`: https://github.com/apache/thrift/blob/2ea47349186d08a60a51e477f85d811a43940a8f/lib/py/src/ext/module.cpp#L92-L99 Consider exposing the same configuration on the new entry point for parity with the existing decode paths. 🤖 Generated with [Claude Code](https://claude.ai/code) <sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
