kpumuk opened a new pull request, #3646:
URL: https://github.com/apache/thrift/pull/3646
<!-- Explain the changes in the pull request below: -->
The native `MemoryBufferTransport#read_into_buffer` implementation delayed
recording its transport position until the whole request completed. If input or
destination capacity ran out after bytes had been copied, the destination
contained those bytes while the transport still treated them as unread.
This change preserves the progress of successfully copied bytes before
raising, so native retry and recovery behavior matches the pure-Ruby
implementation.
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [x] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
[THRIFT-6105](https://issues.apache.org/jira/browse/THRIFT-6105)
- [x] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
