kpumuk opened a new pull request, #3647: URL: https://github.com/apache/thrift/pull/3647
<!-- Explain the changes in the pull request below: --> Native Ruby protocol readers previously assembled fixed-width values through shifts on promoted signed integers. On common builds, those reads can appear to return the expected values, but UBSan exposes the undefined operation for high-bit byte patterns. Before this change, building and running the focused examples from `lib/rb` with: ```sh make -C ext clean all CFLAGS='-fPIC -O1 -g -fsanitize=undefined -fno-sanitize-recover=undefined' DLDFLAGS='-fsanitize=undefined' UBSAN_OPTIONS='halt_on_error=1:print_stacktrace=1' bundle exec rspec spec/binary_protocol_spec.rb spec/compact_protocol_spec.rb --example fixed-width ``` reports: ```text compact_protocol.c:618:42: runtime error: left shift of 128 by 24 places cannot be represented in type 'int' ``` This change builds the binary and compact protocol values with correctly sized unsigned intermediates, then converts to signed values only after assembly. It also preserves double bit patterns when the high bit is set. <!-- We recommend you review the checklist/tips before submitting a pull request. --> - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? [THRIFT-6106](https://issues.apache.org/jira/browse/THRIFT-6106) - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? (not required, but preferred) - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. <!-- The Contributing Guide at: https://github.com/apache/thrift/blob/master/CONTRIBUTING.md has more details and tips for committing properly. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
