Copilot commented on code in PR #3649:
URL: https://github.com/apache/thrift/pull/3649#discussion_r3617980695
##########
lib/rb/lib/thrift/transport/http_client_transport.rb:
##########
@@ -62,7 +62,7 @@ def flush
end
def to_s
- "@{self.url}"
+ "#{@url.scheme}(#{@url.host}:#{@url.port}#{@url.path})"
end
Review Comment:
`to_s` uses `@url.path` directly, but Ruby's `URI` returns an empty string
for root URLs (e.g., `http://example.com`), which would produce an endpoint
label with no path at all. Since this label is intended to include a path,
normalize an empty/nil path to `/` to keep output consistent and unambiguous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
