[ 
https://issues.apache.org/jira/browse/THRIFT-5927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18097746#comment-18097746
 ] 

Carel commented on THRIFT-5927:
-------------------------------

[~jensg] When I build and test master branch locally I get the following error 

{code}
/usr/bin/python test/test_compiler/test_keyword_escape.py
ERROR: thrift compiler failed
stdout: 

stderr: [FAILURE:generation:1] Cannot use reserved language keyword "None" with 
target language Python
make[1]: *** [Makefile:680: check-local] Error 1
make[1]: Leaving directory '/thrift/src/lib/py'
make: *** [Makefile:516: check-am] Error 2
make: Leaving directory '/thrift/src/lib/py'
{code}

On investigation I see the test is not run during CI 
(https://github.com/apache/thrift/actions/runs/29791916313/job/88515694019#step:12:349)
{code}
/opt/hostedtoolcache/Python/3.14.6/x64/bin/python 
test/test_compiler/test_keyword_escape.py
WARNING: thrift compiler not found, skipping test
(In CI, thrift should be available via THRIFT env var)
{code}

Can you maybe look into why it is not running to confirm that the issue is not 
also on master?

>  Cannot use reserved language keyword "None" with target language Python
> ------------------------------------------------------------------------
>
>                 Key: THRIFT-5927
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5927
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Compiler
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>            Priority: Major
>             Fix For: 0.23.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {code}
> enum ProductType {
>   None = 0,
>   FluxCapacitor = 1
> }
> {code}
> The "None" causes issues with Python.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to