Jens-G opened a new pull request, #3668:
URL: https://github.com/apache/thrift/pull/3668

   `testbinaryprotocol.c`'s recursion-depth skip tests 
(`test_skip_recursion_depth` / `test_skip_within_limit`, added in c097d239f) 
use `THRIFT_TYPE_MEMORY_BUFFER`, but `testbinaryprotocol_LDADD` in 
`lib/c_glib/test/Makefile.am` does not link `thrift_memory_buffer`.
   
   As a result `testbinaryprotocol` fails to build under the **autotools** 
build:
   
   ```
   undefined reference to `thrift_memory_buffer_get_type'
   ```
   
   The **cmake** build links the whole `libthrift_c_glib` library, so it is 
unaffected — which is why this stayed green in CI. This adds the missing object 
to the link line, matching the other tests that use the memory buffer 
(`testbufferedtransport`, `testframedtransport`).
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to