kpumuk opened a new pull request, #3674:
URL: https://github.com/apache/thrift/pull/3674
<!-- Explain the changes in the pull request below: -->
The Ruby serializer clears its memory buffer between calls but reuses the
same protocol object. JSON protocols also retain nested-container and separator
state, so an exception during an object's `write` method can leave the
serializer positioned inside the failed value. Later serializations may then
begin with a stale comma or colon and produce malformed JSON.
This change retains normal protocol reuse for successful calls. If
serialization raises, it discards the protocol while preserving the original
exception; the next call lazily creates a clean protocol from the configured
factory. Subsequent output therefore matches a fresh serializer without adding
protocol allocations to the successful hot path.
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [x] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
[THRIFT-6123](https://issues.apache.org/jira/browse/THRIFT-6123)
- [x] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
