Jens-G commented on PR #3667:
URL: https://github.com/apache/thrift/pull/3667#issuecomment-5097153819
### Code review
No issues found. Checked for bugs and CLAUDE.md compliance.
Suggestion (non-blocking, not a defect):
The new readiness timeout raises from inside the `except (OSError,
ValueError)` handler without `from None`, so a genuine timeout prints a "During
handling of the above exception, another exception occurred" chain above the
real message. The message also drops the elapsed time that the old `"TestServer
not ready on port %d after %.2f seconds"` carried; the port itself is
legitimately unknown here, but the port-file path would be the useful
substitute. For a harness whose job is diagnosing flakes, `raise Exception("...
after %.2f seconds (%s)" % (...)) from None` would read better in CI logs.
https://github.com/apache/thrift/blob/be02ff78fd1663e988e62c6655535ec8076ca7ee/test/py/RunClientServer.py#L161-L166
🤖 Generated with [Claude Code](https://claude.ai/code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
