kpumuk opened a new pull request, #3679: URL: https://github.com/apache/thrift/pull/3679
<!-- Explain the changes in the pull request below: --> Ruby deserialization populates an object supplied by the caller, but previously did not clear values left by an earlier read. When a later payload omitted a field, the target could retain stale data from the previous message. Reused unions could similarly retain their previous discriminator and value after unknown or incomplete input. This change resets structs and unions before reading a new value. Struct defaults are restored using fresh copies, while fields without defaults are cleared. The native extension performs the same work directly in C and skips the reset scan for fresh targets, preserving parity without adding a Ruby callback to the accelerated read path. <!-- We recommend you review the checklist/tips before submitting a pull request. --> - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? [THRIFT-6124](https://issues.apache.org/jira/browse/THRIFT-6124) - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? (not required, but preferred) - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. <!-- The Contributing Guide at: https://github.com/apache/thrift/blob/master/CONTRIBUTING.md has more details and tips for committing properly. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
