kpumuk opened a new pull request, #3680:
URL: https://github.com/apache/thrift/pull/3680
<!-- Explain the changes in the pull request below: -->
Ruby clients currently close their output transport when argument
serialization fails, but leave it reusable when writing the message envelope,
finishing the message, or flushing fails. At that point, request delivery may
be partial or otherwise uncertain, so a subsequent call can reuse transport
state that no longer has a reliable request boundary.
This change prepares generated arguments before consuming a sequence ID or
writing message bytes. Once message output begins, envelope writing, argument
serialization, message completion, and flushing share one failure boundary that
closes the output transport while preserving the original exception. Ordinary
calls are added to the pending-reply queue only after a successful flush, and
oneway calls follow the same transport-closing behavior.
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [x] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
[THRIFT-6125](https://issues.apache.org/jira/browse/THRIFT-6125)
- [x] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
