kpumuk opened a new pull request, #3681:
URL: https://github.com/apache/thrift/pull/3681
<!-- Explain the changes in the pull request below: -->
Ruby Compact and JSON protocol implementations currently allow unknown field
and container type identifiers to escape as generic runtime exceptions. In
`SimpleServer`, those exceptions can leave the per-connection protocol error
path and stop the accept loop, preventing a later valid client from being
processed.
This change reports unknown Compact and JSON types as
`ProtocolException::INVALID_DATA`. The native and pure-Ruby Compact
implementations now expose matching exception metadata and preserve the
original invalid writer type in diagnostics. `SimpleServer` can therefore close
only the malformed connection and continue accepting clients.
The fuzz harness now relies on these typed exceptions and drops obsolete
message matching for invalid types, union validation, negative container sizes,
and JSON encoding failures.
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [x] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
[THRIFT-6126](https://issues.apache.org/jira/browse/THRIFT-6126)
- [x] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
