vikrantpuppala opened a new pull request, #3685:
URL: https://github.com/apache/thrift/pull/3685
## Summary
- constrain `uuid` to `^11.1.1`, the latest line that provides both CommonJS
and ESM conditional exports
- preserve the existing UUID parse/stringify and generated-code `v4` APIs
- add regression coverage for Node/browser CommonJS exports, package
loading, and binary/compact UUID round trips
## Motivation
The Node.js runtime and generated CommonJS code load `uuid` with
`require()`, but `uuid` 12 and newer are ESM-only. Consequently,
`require("thrift")` fails in CommonJS tooling such as Jest before application
tests execute.
Downstream reproduction:
https://github.com/databricks/databricks-sql-nodejs/issues/461
## Test plan
- `npm run lint-tests`
- `npx prettier --check lib/nodejs/test/uuid.test.js`
- `node lib/nodejs/test/binary.test.js`
- `node lib/nodejs/test/header.test.js`
- `node lib/nodejs/test/uuid.test.js` on Node 16 and Node 24
- packed-tarball Jest smoke test on Node 20 and Node 24
- packed consumer production audit: 0 vulnerabilities
The broad `npm run lint` command remains red on existing legacy files on
`master`; the changed test file and the complete Node.js test directory pass
ESLint.
Generated-by: OpenAI Codex (GPT-5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
