zsy056 commented on PR #3689: URL: https://github.com/apache/thrift/pull/3689#issuecomment-5133826094
> > required fields can move to default requiredness when intentionally enabled > > But you are aware that this breaks your contract? IOW that is what audit is designed to check. Hi Jens I was using thrift as the internal RPC implementation of a micro-service, for this scenario, the contract is the client API of our micro-service, not the thrift definition itself. I found audit to be externally helpful to prevent issues on wire protocol incompatibility, it is used as part of a check-in gate. However, over the years, things have changed enough that we have to including remove some optional and slowly deprecate some required fields. The current audit mode doesn’t provide the flexibility and we also definitely don’t want to drop audit entirely in the check-in gate. So I suppose if these relaxations are behind some command line option and is default to off, it should be safe for all existing users while still provide flexibility? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
