SLAVONchick commented on code in PR #3666:
URL: https://github.com/apache/thrift/pull/3666#discussion_r3747034461
##########
lib/cpp/test/TTransportFactoryConfigTest.cpp:
##########
@@ -104,7 +104,8 @@
BOOST_AUTO_TEST_CASE(test_piped_transport_factory_preserves_configuration) {
// failing on a truncated buffer.
BOOST_AUTO_TEST_CASE(test_framed_transport_factory_enforces_custom_max_frame_size)
{
const int kMaxFrameSize = 64;
- auto config =
std::make_shared<TConfiguration>(TConfiguration::DEFAULT_MAX_MESSAGE_SIZE,
kMaxFrameSize);
+ const int kMaxMessageSize = TConfiguration::DEFAULT_MAX_MESSAGE_SIZE;
+ auto config = std::make_shared<TConfiguration>(kMaxMessageSize,
kMaxFrameSize);
Review Comment:
Removed this from this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
