kpumuk opened a new pull request, #3712:
URL: https://github.com/apache/thrift/pull/3712
<!-- Explain the changes in the pull request below: -->
Ruby `HeaderTransport` currently applies `max_frame_size` to the payload
before constructing the Header frame. The reader applies the same limit to the
complete size declared on the wire, which also includes the fixed Header
envelope, transformed payload, metadata, and padding. A writer can therefore
emit a frame that a reader configured with the identical limit rejects.
This change validates the completed declared Header frame after transforms
and header construction, before writing any bytes. The four-byte length prefix
remains excluded, matching the read-side contract; each Header field and
payload byte is counted exactly once. Framed and unframed Binary/Compact
compatibility modes keep their existing accounting. Pending one-shot headers
also remain available when this local validation rejects a frame before
delivery.
## Benchmarks
The repository Header write benchmark ran 10,000 small-structure writes per
scenario for six trials, with the first trial discarded as warm-up:
```text
ruby /thrift/src/test/rb/benchmarks/protocol_benchmark.rb \
--scenarios hdr-bin-write-small,hdr-cmp-write-small,hdr-zlib-write-small \
--small-runs 10000 \
--json
```
Pure-Ruby controls used the identical command with
`THRIFT_BENCHMARK_SKIP_NATIVE=1`. Current master and the proposed change used
the same Ruby container and rebuilt native extension. Times are median seconds,
with the measured five-trial range in parentheses.
| Mode | Scenario | Master | Proposed | Delta |
|---|---|---:|---:|---:|
| Native | Header Binary | 0.153373 (0.150825–0.159381) | 0.154013
(0.151142–0.155030) | +0.42% |
| Native | Header Compact | 0.128464 (0.121187–0.132505) | 0.128461
(0.125729–0.132922) | 0.00% |
| Native | Header ZLIB | 0.206152 (0.204393–0.210734) | 0.205150
(0.201781–0.207064) | -0.49% |
| Pure Ruby | Header Binary | 0.200360 (0.197171–0.210889) | 0.198534
(0.192370–0.205776) | -0.91% |
| Pure Ruby | Header Compact | 0.204374 (0.202167–0.207060) | 0.204823
(0.200498–0.211956) | +0.22% |
| Pure Ruby | Header ZLIB | 0.251476 (0.248048–0.254244) | 0.250412
(0.248805–0.261224) | -0.42% |
All before-and-after ranges overlap; the results show no meaningful
performance change.
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [x] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
[THRIFT-6148](https://issues.apache.org/jira/browse/THRIFT-6148)
- [x] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
