Copilot commented on code in PR #3713:
URL: https://github.com/apache/thrift/pull/3713#discussion_r3783693002
##########
lib/rb/lib/thrift/protocol/base_protocol.rb:
##########
@@ -231,6 +231,10 @@ def read_uuid
raise NotImplementedError
end
+ def skip_string
+ read_string
+ end
Review Comment:
`skip_string` is a new public protocol hook used by `BaseProtocol#skip`, but
it currently lacks any documentation about when to override it and what
semantics are expected. Adding a short doc comment here will help custom
protocol implementers understand that they can override this to skip STRING
values without UTF-8 decoding (while the default preserves existing behavior
via `read_string`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
