Copilot commented on code in PR #3717: URL: https://github.com/apache/thrift/pull/3717#discussion_r3791985428
########## test/rb/integration/TestServer.rb: ########## @@ -31,9 +31,11 @@ require "optparse" class SimpleHandler - [:testVoid, :testString, :testBool, :testByte, :testI32, :testI64, :testDouble, :testBinary, - :testStruct, :testMap, :testStringMap, :testSet, :testList, :testNest, :testEnum, :testTypedef, - :testEnum, :testTypedef, :testMultiException, :testUuid].each do |meth| + [ + :testVoid, :testString, :testBool, :testByte, :testI32, :testI64, :testDouble, :testBinary, + :testStruct, :testMap, :testStringMap, :testSet, :testList, :testNest, :testEnum, :testTypedef, + :testEnum, :testTypedef, :testMultiException, :testUuid, Review Comment: The method list contains duplicated entries (:testEnum and :testTypedef), which causes define_method to run twice for the same method names (redundant redefinition). Removing the duplicates keeps the handler definition simpler and avoids unnecessary work at load time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
