Copilot commented on code in PR #3726:
URL: https://github.com/apache/thrift/pull/3726#discussion_r3793126832
##########
lib/rb/lib/thrift/protocol/json_protocol.rb:
##########
@@ -509,15 +509,15 @@ def read_json_string(skipContext = false)
# The elements of this array must match up with the sequence of
characters in
# escape_chars
escape_char_vals = [
- "\"", "\\", "\/", "\b", "\f", "\n", "\r", "\t",
+ "\"", "\\", "/", "\b", "\f", "\n", "\r", "\t",
]
Review Comment:
The comment above `escape_chars` is now misleading: it says '/' is not
included, but `escape_chars` ("\\/") and `escape_char_vals` both handle '/' (as
optional `\/` in JSON). Please update the comment to reflect the actual
behavior and current RFC reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
