kpumuk opened a new pull request, #3729:
URL: https://github.com/apache/thrift/pull/3729
<!-- Explain the changes in the pull request below: -->
Enable `Lint/UselessAssignment` and remove assignments whose values are
never read across the Ruby library, benchmarks, specs, integration client, and
tutorial.
The Ruby generator now binds decoded service arguments and results only when
generated methods consume them. Focused functional coverage verifies
zero-argument processor methods and void client receivers. The Ruby cross-test
client also exercises its escape/junk string and multilingual string
separately, fixing an overwritten test input exposed by the cop.
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
([Request account here](https://selfserve.apache.org/jira-account.html), not
required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
