fishy commented on code in PR #3733: URL: https://github.com/apache/thrift/pull/3733#discussion_r3818791141
########## test/keys/keygen/make-serverkey.sh: ########## @@ -48,7 +48,6 @@ echo '' >> my.cfg echo '[ alternate_names ]' >> my.cfg echo 'IP.1=127.0.0.1' >> my.cfg echo 'IP.2=::1' >> my.cfg -echo 'IP.3=::ffff:127.0.0.1' >> my.cfg Review Comment: @Jens-G I have to remove this, as this is no longer supported by go 1.27 (https://github.com/golang/go/commit/a5b2a19336774bf0f59a0d43eafdb66b3f1c1c5b). With this we can't even get to crosstest. But after removed this I see all the crosstests with java/kotlin as client failed the ssl ones, so maybe this was added to make java/kotlin clients to pass ssl crosstests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
