sveneld opened a new pull request, #3796: URL: https://github.com/apache/thrift/pull/3796
## Summary - add a regression test that keeps `TSocket::close()` effective for persistent PHP sockets - lock in the current behavior that lets callers recycle a persistent connection after failure, matching the long-standing `THRIFT-2151` expectation - align two existing `TSocketTest` cases with the current typed constructor and deprecation-capture helper shape so the file can execute cleanly on 2026-09-03 `master` ## Testing - `docker run --rm -v /home/v.panivko/github/thrift:/thrift -w /thrift thrift-php-dev:local vendor/bin/phpunit -c lib/php/phpunit.xml lib/php/test/Unit/Lib/Transport/TSocketTest.php` Generated-by: OpenAI Codex GPT-5 <[email protected]> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
