slachiewicz commented on PR #3806: URL: https://github.com/apache/thrift/pull/3806#issuecomment-5561175554
Rebased onto master now that #3788 has landed, which is what the two `lib-go` failures were about. THRIFT-6175 added `TestStructKeyEqualsDetectsKeyDifference/entry_order_only`, asserting that reordering entries changes equality, plus a README paragraph saying the same. Both describe exactly the behaviour this change removes. The assertion is now its opposite, as `TestStructKeyEqualsIgnoresEntryOrder`, and the entry-slice section of the README says a map is compared as a collection. I missed it locally because the branch was cut before #3788 merged, so neither the test nor the paragraph existed in my tree. *This comment was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
