[
https://issues.apache.org/jira/browse/THRIFT-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz resolved THRIFT-4386.
------------------------------------------
Fix Version/s: 0.22.0
Resolution: Fixed
Lua 5.3/5.4 support landed in
[eb684d34|https://github.com/apache/thrift/commit/eb684d34853c9a8ab7a2759c1c88ae3dfa1b0ef6]
— patch by Thomas Bruggink, committed by Jens Geyer in July 2024; first
released in 0.22.0. Two loose ends remain on master, noted here:
[configure.ac|https://github.com/apache/thrift/blob/master/configure.ac] line
279 still calls {{AX_PROG_LUA(5.2,...)}}, and
[README.md|https://github.com/apache/thrift/blob/master/build/docker/README.md]
line 190 still points at this ticket for Lua 5.3. Resolving as Fixed; those two
lines can be cleaned up whenever someone touches the build.
> Add Lua 5.3 Support
> -------------------
>
> Key: THRIFT-4386
> URL: https://issues.apache.org/jira/browse/THRIFT-4386
> Project: Thrift
> Issue Type: Improvement
> Components: Lua - Library
> Affects Versions: 0.10.0
> Environment: ubuntu-artful docker image with "lua5.3", "lua5.3-dev",
> and lua5.3 symbolically linked to lua, and luac5.3 symbolically linked to
> luac (all in usr/bin)
> Reporter: James E. King III
> Priority: Major
> Fix For: 0.22.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Looks like our old socket code uses a call no longer in lua which was
> deprecated in 5.1:
> {noformat}
> root@8f527334cf62:/thrift/src# cat
> test/log/cpp-lua_binary_buffered-ip_client.log
> Sun Nov 19 13:56:05 2017
> Executing: lua test_basic_client.lua --protocol=binary --transport=buffered
> --port=35407
> Directory: /thrift/src/test/lua
> config:delay: 5
> config:timeout: 5
> ===============================================================================
> lua: error loading module 'libluasocket' from file
> '../../lib/lua/.libs/libluasocket.so':
> ../../lib/lua/.libs/libluasocket.so: undefined symbol: luaL_openlib
> stack traceback:
> [C]: in ?
> [C]: in function 'require'
> ../../lib/lua/TSocket.lua:20: in main chunk
> [C]: in function 'require'
> test_basic_client.lua:19: in main chunk
> [C]: in ?
> ===============================================================================
> Return code: 1
> Test execution took 0.0 seconds.
> Sun Nov 19 13:56:05 2017
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
