[
https://issues.apache.org/jira/browse/THRIFT-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18112774#comment-18112774
]
Sylwester Lachiewicz edited comment on THRIFT-2242 at 9/8/26 1:45 PM:
----------------------------------------------------------------------
THRIFT-4720 made the library C++11, which covers this ticket's title but not
its content. The generator still emits ordered containers — {{std::map}},
{{std::set}} and {{std::vector}} at
[t_cpp_generator.cc:4823|https://github.com/apache/thrift/blob/master/compiler/cpp/src/thrift/generate/t_cpp_generator.cc#L4823]
— and no {{noexcept}}. Moving to {{std::unordered_map}} and
{{std::unordered_set}} changes the iteration order of every generated
container, so this is an API decision rather than a defect. Reopening as that
decision; the 0.13.0 fix version does not apply.
was (Author: slachiewicz):
THRIFT-4720 made the library C++11, which covers this ticket's title but not
its content. The generator still emits ordered containers — {{std::map}},
{{std::set}} and {{std::vector}} at
[t_cpp_generator.cc:4823|https://github.com/apache/thrift/blob/master/compiler/cpp/src/thrift/generate/t_cpp_generator.cc#L4823]
— and no {{noexcept}}. Moving to {{std::unordered_map}} and
{{std::unordered_set}} changes the iteration order of every generated
container, so this is an API decision rather than a defect. Reopening as that
decision; the 0.13.0 fix version does not apply.
> Generate C++11 code (THRIFT-4720 made us C++11, rename this)
> ------------------------------------------------------------
>
> Key: THRIFT-2242
> URL: https://issues.apache.org/jira/browse/THRIFT-2242
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.1
> Reporter: Vitali Lovich
> Priority: Major
>
> unordered_map instead of map, unordered_set instead of set, noexcept instead
> of throw() (unless the exact semantics of throw() are needed which seems
> unlikely).
> It should use the shared_ptr implementation that the library is configured
> with.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
