Jens Geyer created THRIFT-6217:
----------------------------------

             Summary: Four test programs are built and run only by the 
autotools build, never by CMake/ctest
                 Key: THRIFT-6217
                 URL: https://issues.apache.org/jira/browse/THRIFT-6217
             Project: Thrift
          Issue Type: Bug
          Components: Build Process, Test Suite
            Reporter: Jens Geyer


Four test programs are listed in an autotools {{check_PROGRAMS}} but do not 
appear in the matching {{CMakeLists.txt}} at all, so a CMake build neither 
builds nor runs them:

||Library||Test program||autotools||CMake||
|C++|{{RenderedDoubleConstantsTest}}|{{lib/cpp/test/Makefile.am}}|not present|
|c_glib|{{testcontainertest}}|{{lib/c_glib/test/Makefile.am}}|not present|
|c_glib|{{testtransportsslsocket}}|{{lib/c_glib/test/Makefile.am}}|not present|
|c_glib|{{teststruct}}|{{lib/c_glib/test/Makefile.am}}|not present|

Found by comparing the {{check_PROGRAMS}} / {{TESTS}} lists with the 
{{add_test}} names on master. The C++ programs that exist only on the CMake 
side ({{Benchmark}}, {{concurrency_test}}) are {{noinst_PROGRAMS}} in 
autotools, which looks deliberate and is not part of this.

Suggested: add the four to CMake with {{add_test}}, under whatever condition 
the autotools build applies to each, or record why they are autotools-only.

_Drafted with AI assistance (Claude Opus 5); reviewed and filed by Jens Geyer._



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to