slachiewicz commented on PR #3826: URL: https://github.com/apache/thrift/pull/3826#issuecomment-5635026575
Rewrote the branch after the review above: - The Homebrew line now installs `automake libtool pkg-config` as the macOS CI job does, so `./bootstrap.sh` finds libtoolize. - Both recipes build only the compiler, which is what the page promises: `--disable-libs --disable-tests` for Autotools and `-DBUILD_LIBRARIES=OFF -DBUILD_TESTING=OFF -DBUILD_TUTORIALS=OFF` for CMake. Neither needs Boost, libevent or OpenSSL, so those moved to a sentence for readers who also want the C++ library. - Dropped the `LDFLAGS` export and the "(Recommended)" label. - The CMake recipe now builds into `cmake-build`. `cmake -B build` reuses the repository's own `build/` directory, which holds the CMake modules. - The commit carries the attribution trailer. Verified: both recipes run as written on macOS 15 (Apple Silicon) → `thrift -version` prints 0.25.0 from each build. *This comment was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
