Jens-G commented on PR #3824: URL: https://github.com/apache/thrift/pull/3824#issuecomment-5634152777
### Code review Found 1 issue: 1. The commit has no AI attribution trailer, although the PR description says the change was created with AI assistance (AGENTS.md says "**Always** label AI-assisted commits and PRs. Use one or both of: `Co-Authored-By: <AI tool name and version>` / `Generated-by: <AI tool name and version>`"). The PR text does not name a tool or version either. https://github.com/apache/thrift/blob/ed73d68708a583e2ddcf0080ec35280fbcc7a9e0/AGENTS.md#L60-L74 One suggestion, below the bar for the list above but verified: - `clean-local` loses its guard for an unconfigured build tool. The old recipe carried "Make sure this doesn't fail if ant is not configured", which f9b5b12f4 added because `make distclean` enters the Java directories even when Java is disabled. In that case `$(GRADLE)` is empty and the new recipe runs `clean --console=plain`. `tutorial/js` still has the guard. `lib/java` and `lib/kotlin` already lack it, so in practice this is mainly about keeping `tutorial/java` in line with its sibling. https://github.com/apache/thrift/blob/ed73d68708a583e2ddcf0080ec35280fbcc7a9e0/tutorial/java/Makefile.am#L21-L24 🤖 Generated with [Claude Code](https://claude.ai/code) <sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
