slachiewicz opened a new pull request, #3844: URL: https://github.com/apache/thrift/pull/3844
Follow-up to [THRIFT-5952](https://issues.apache.org/jira/browse/THRIFT-5952). The MSVC CI image is 6.3 GiB compressed and every run pulls all of it, because the `windows-2025` runners pre-cache no container images. The last full rebuild took 53 minutes against the 60 minute step timeout. Measurements and the full list of findings are in [THRIFT-6237](https://issues.apache.org/jira/browse/THRIFT-6237). What the diff does not show: - The .NET Framework SDK base (4.0 GiB compressed) contributed only the dotnet CLI. C++ compiles with the separately installed VS 2022 Build Tools (`MSVC 19.44` in the CMake log), and all `lib/netstd` test projects target `net10.0`. The .NET 10 SDK image is 2.7 GiB. - jdk8 (377 MiB) was never used: the CMake summary reports the Java library OFF because Gradle is missing. - cmd treats `&& next` after `IF ...` or `FOR ... DO` as part of that command's body. The `SETX` calls that followed the cleanup loops therefore ran once per loop iteration, or only when the directory existed. The loops are now parenthesised and placed after the environment writes, and PATH is written to the machine-scope registry key, which has no 1024 character SETX limit. - The workflow hashed only the Dockerfile for the image tag, so editing the two `COPY`'d appveyor scripts never produced a new image. - OpenSSL moves to 3.6.4. slproweb no longer serves the 3.6.2 installer, so master's Dockerfile currently fails to build at that step ([fork run](https://github.com/slachiewicz/thrift/actions/runs/34598853800)). - Node.js is pinned to the LTS line (24.20.0), a change from whatever the unpinned `nodejs` package resolved to when the current image was built. Verified: fork run [34598853800](https://github.com/slachiewicz/thrift/actions/runs/34598853800) → every step up to OpenSSL builds on the new base (Build Tools, CMake, Boost, Chocolatey, libevent, zlib). The run with OpenSSL 3.6.4 is [34601324285](https://github.com/slachiewicz/thrift/actions/runs/34601324285), in progress when this PR was opened. - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? - [x] Did you do your best to avoid breaking changes? - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. *This change was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
