[
https://issues.apache.org/jira/browse/THRIFT-6265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-6265.
--------------------------------
Fix Version/s: 0.25.0
Assignee: Jens Geyer
Resolution: Fixed
> Python: setup.py still carries the backports.ssl_match_hostname dependency
> for Python < 3.5
> -------------------------------------------------------------------------------------------
>
> Key: THRIFT-6265
> URL: https://issues.apache.org/jira/browse/THRIFT-6265
> Project: Thrift
> Issue Type: Improvement
> Components: Python - Library
> Reporter: Jens Geyer
> Assignee: Jens Geyer
> Priority: Trivial
> Fix For: 0.25.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{lib/py/setup.py:107}}:
> {code:python}
> if sys.hexversion < 0x03050000:
> ssl_deps.append('backports.ssl_match_hostname>=3.5')
> {code}
> The package requires Python 3 and CI builds from 3.10 upward, so the branch
> cannot be taken by any interpreter the library supports.
> {{ssl.match_hostname}} itself was removed from the standard library in 3.12,
> which is the direction the shim was there to cover in the other direction.
> h2. Suggested
> Drop the branch and the {{backports.ssl_match_hostname}} dependency.
> _Drafted with AI assistance (Claude Opus 5); reviewed and filed by Jens
> Geyer._
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
