Jens-G opened a new pull request, #3874: URL: https://github.com/apache/thrift/pull/3874
JIRA: [THRIFT-6284](https://issues.apache.org/jira/browse/THRIFT-6284) Client: d,lua,py Follow-up to THRIFT-6270. The sweep for source and test files that no build list references found, beyond the PR #3870 PHP case, three more: ### lib/lua — the `.lua` modules were never installed The twelve modules were in `EXTRA_DIST` only, so `make install` delivered the four C libraries and none of the Lua source; an installed copy was unusable. They now install into `luadir` through `dist_lua_DATA`. They are required by their bare name (`require 'TTransport'`), so the flat `luadir` layout is correct. - **Verified:** `make -C lib/lua install DESTDIR=…` now lays down all twelve (`luadir = ${prefix}/share/lua/5.4`); on master it lays down none. ### lib/d — `thrift/codegen/idlgen.d` was in no module list It was commented out of `d_codegenmodules` in 2014 (THRIFT-2781, "temporarily … to be fixed later") and never restored, so the autotools build did not compile, install or unit-test it; only the `dub` build did. It compiles cleanly now. - **Verified:** with `idlgen` back in the list, `make -C lib/d check` builds it into `libthriftd.a` and its unit tests pass in both debug and release (`PASS: unittest/debug/thrift/codegen/idlgen`, `…/release/…`). (The subsequent test-codegen step needs the compiler binary at `../../compiler/cpp/thrift`, unrelated to this change; the library build and the `idlgen` unit test run before it.) ### lib/py — `test/test_sasl_transport.py` was in no test list Added for THRIFT-5926 but named in neither `Makefile.am` nor `CMakeLists.txt`, so CI never ran it. Registered in both. It stubs `puresasl` itself, so it needs no extra dependency. - **Verified:** runs green (7 tests) on the built library. The Android Gradle build, a fourth sweep finding, is filed separately as THRIFT-6285 for a decision (unmaintained, no CI), not fixed here. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
