Jens-G commented on PR #3854: URL: https://github.com/apache/thrift/pull/3854#issuecomment-5721154529
Thanks — THRIFT-6290 settles the ticket point. Yes please, add the recording transport in this PR. "Skipping a 1024-byte string never asks for more than 256 bytes" is exactly the two-state signal the current tests are missing: they pass either way, because the old and the new path consume the same bytes and return the same errors. Worth covering all three places the forward can be lost, not just the protocols themselves: `TBinaryInputProtocol` / `TCompactInputProtocol`, the `Box<P>` impl, and `TStoredInputProtocol`. If a `skip_binary` forward is dropped in either wrapper it silently falls back to the allocating default, and nothing else in the suite would notice. 🤖 Generated with [Claude Code](https://claude.ai/code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
