Jens-G opened a new pull request, #3886: URL: https://github.com/apache/thrift/pull/3886
Nothing in the tree built or tested `lib/javame`. It has no `Makefile.am` and no `configure.ac` entry, only a place in `lib/Makefile.am`'s `EXTRA_DIST`. So it ships in the release tarball without any build ever having compiled it, and the last changes to it had to be compiled and run by hand. ### The job `lib-javame` does what the headers of the tests in `lib/javame/test` describe: 1. It generates the types `TestRecursionDepth` needs from `test/RecursionDepth.thrift`. 2. One `javac` run on Temurin 17 compiles the library, that generated code and the tests. 3. It runs every `test/Test*.java`. `THttpClient.java` stays out, as in those recipes. It needs `javax.microedition.io`, which no JDK provides and which is not available under a license an ASF build can use: Oracle's CLDC is proprietary, and microemu is LGPL. That leaves 39 of the 40 source files. This is a compile-and-smoke check, not a job like the other bindings have. `lib/javame` has no server transport and no entry in `test/tests.json`, so cross tests are out of scope. A JDK also accepts APIs that a CLDC device lacks. A green run therefore shows that the code compiles and its tests pass, not that it runs on such a device. ### Verification I ran the job's own `run:` blocks in an `eclipse-temurin:17-jdk` container: ``` javac: 39 sources + 4 generated + 3 tests, only deprecation/unchecked notes TestDeclaredLengthLimits 9 checks, 0 failures TestRecursionDepth 18 checks, 0 failure(s) TestSkipDepth 5 checks, 0 failures ``` The job fails at the right step in each negative case: - a failing check, whether the test exits 1 or throws: at the test step; - a syntax error in `src`: at the compile step; - a second file importing `javax.microedition`: at the compile step. zizmor shows no new findings. Actions are disabled on my fork, so this PR is the job's first run on GitHub. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
