sveneld opened a new pull request, #3892: URL: https://github.com/apache/thrift/pull/3892
Remove the PHP runtime deprecation paths that were introduced in 0.24.0 and announced for removal in the next version. ## Affected APIs * `TSocket` constructor no longer accepts a callable or function-name string as `$debugHandler`; only `Psr\Log\LoggerInterface` is accepted. * Removed `TSocket::DEFAULT_DEBUG_HANDLER` constant. * Removed `TSocket::setDebug()` method. * Removed the `E_USER_DEPRECATED` notice in `TSocket::open()` when `setSendTimeout()` is reused as the connect timeout; callers should use `setConnectTimeout()` explicitly. * `TSSLSocket` and `TSocketPool` constructors accept only `?LoggerInterface` for `$debugHandler`. * Removed public `TSSLServerSocket::getSSLHost()` method (the `ssl://` prefix is applied automatically by the constructor). ## Breaking change This is a breaking change. The migration path is to pass a `Psr\Log\LoggerInterface` instance to the transport constructors and to call `TSocket::setConnectTimeout()` when a dedicated connect timeout is needed. The breaking change is documented in `lib/php/README.md`. ## Testing Unit tests were updated to use the `LoggerInterface` API and to remove the now-obsolete deprecation assertions. The PHP cross-test client already uses a PSR-3 logger and required only a comment update. Client: php -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
